Repository navigation
Remove Cosmetica from legacy defaults and documented load lists - #391
Merged
Merged
Conversation
Co-authored-by: xfl03 <3205159+xfl03@users.noreply.github.com>
Copilot
AI
changed the title
Remove Cosmetica support from default list
Remove Cosmetica from legacy defaults and documented load lists
Aug 11, 2026
xfl03
marked this pull request as ready for review
August 11, 2026 13:52
There was a problem hiding this comment.
Pull request overview
Removes the Cosmetica legacy cape provider from MCCustomSkinLoader’s shipped legacy default profile list and updates README sections so the documented supported/default provider lists match the runtime defaults.
Changes:
- Removed the
Cosmeticaentry fromLegacyLoader#getDefaultProfiles()legacy default profiles. - Removed Cosmetica references from README “Supported special skin sites and profiles” and “Default Load List”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Removes Cosmetica from documented supported/default provider lists to match runtime defaults. |
| Common/src/main/java/customskinloader/loader/LegacyLoader.java | Removes Cosmetica from legacy default profiles while preserving remaining ordering/priorities. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Common/src/main/java/customskinloader/loader/LegacyLoader.java:32
- The commented-out LabyMod entry can no longer be enabled by simply uncommenting it because
CloakPlusis now the last argument (no trailing comma). If you want to keep this as an optional entry, rewrite it so the separating comma lives inside the comment block, so toggling it won’t require additional edits.
getCapeProfile(this, "CloakPlus", "http://161.35.130.99/capes/{USERNAME}.png", 840)
//getCapeProfile(this, "LabyMod", "https://dl.labymod.net/capes/{STANDARD_UUID}", 850)
);
Co-authored-by: xfl03 <3205159+xfl03@users.noreply.github.com>
Owner
xfl03
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes Cosmetica from the repository’s default cape provider set and aligns documentation with runtime behavior. The default list now excludes Cosmetica in both code and README references.
Runtime default profile changes
Cosmeticalegacy cape profile entry fromLegacyLoader#getDefaultProfiles().Documentation alignment
Code example (updated default legacy entries)